Skip to content

#1926 - apple 2nd try (use this one) #2374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

#1926 - apple 2nd try (use this one) #2374

wants to merge 1 commit into from

Conversation

swyxio
Copy link

@swyxio swyxio commented Aug 7, 2025

special PR for eric

Here’s a technical recap of what was changed in the Prisma extension to support Prisma 6.6.0+:

Technical Recap: Prisma Extension Updates for Prisma 6.6.0+

1. Explicit Schema and Output Path Handling

  • The extension now requires an explicit schema and output path for the Prisma client, matching Prisma 6.6.0+ requirements.
  • These can be provided either in the extension options or in a prisma.config.ts file.

2. Support for prisma.config.ts

  • The extension detects and parses a prisma.config.ts file if it exists in the project.
  • If present, it uses the schema and output values from this config file unless they are overridden in the extension options.

3. Removed Directory Inference

  • The extension no longer infers the schema directory by checking if the parent folder is named schema.
  • All directory and file paths must now be explicitly provided.

4. Migrations Directory Handling

  • The extension expects the migrations directory to be located alongside the schema.prisma file.
  • During the build, it copies the migrations from this location if migrations are enabled.

5. Prisma Client Output

  • The Prisma client is no longer assumed to be generated in node_modules.
  • The extension uses the explicit output path for the generated client, as required by Prisma 6.6.0+.

6. Error Handling

  • The extension throws clear errors if required paths (schema or output) are missing or misconfigured, making misconfigurations easier to debug.

7. Refactored Build Logic

  • All build steps (copying schema, migrations, generating client) now use the explicit paths.
  • The extension is compatible with both legacy and new Prisma setups, but is optimized for 6.6.0+.

Summary:
The extension was refactored to require explicit configuration for schema and client output, support prisma.config.ts, remove all directory inference, and ensure compatibility with Prisma 6.6.0+’s new requirements for client generation and schema location. All build logic now uses these explicit paths, and error handling is improved for easier troubleshooting.

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Aug 7, 2025

⚠️ No Changeset found

Latest commit: f542c0f

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@coderabbitai coderabbitai
Copy link
Contributor

coderabbitai bot commented Aug 7, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing Touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai generate unit tests to generate unit tests for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@swyxio swyxio changed the title #1926 - updates #1926 - apple 2nd try (use this one) Aug 7, 2025
@ericallam ericallam closed this Aug 13, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@swyxio @ericallam